clarify return value of cifs_convert_flags()
authorJeff Layton <jlayton@redhat.com>
Wed, 14 May 2008 17:21:33 +0000 (10:21 -0700)
committerSteve French <sfrench@us.ibm.com>
Wed, 14 May 2008 18:44:35 +0000 (18:44 +0000)
cifs_convert_flags returns 0x20197 in the default case. It's not
immediately evident where that number comes from, so change it
to be an or'ed set of flags. The compiler will boil it down anyway.

(Thanks to Guenter Kukkukk for clarifying the flags).

Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/file.c

index 31a0a33b9d95450ea0fe8d6461f2249bf68d0f88..8636cec2642c66e285fba1ae0ef79ce1fa2a1026 100644 (file)
@@ -75,7 +75,11 @@ static inline int cifs_convert_flags(unsigned int flags)
                return (GENERIC_READ | GENERIC_WRITE);
        }
 
-       return 0x20197;
+       return (READ_CONTROL | FILE_WRITE_ATTRIBUTES | FILE_READ_ATTRIBUTES |
+               FILE_WRITE_EA | FILE_APPEND_DATA | FILE_WRITE_DATA |
+               FILE_READ_DATA);
+
+
 }
 
 static inline int cifs_get_disposition(unsigned int flags)