pinctrl: aspeed: Clarify comment about strapping W1C
authorAndrew Jeffery <andrew@aj.id.au>
Fri, 28 Jun 2019 02:38:36 +0000 (12:08 +0930)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 3 Jul 2019 08:35:21 +0000 (10:35 +0200)
Writes of 1 to SCU7C clear set bits in SCU70, the hardware strapping
register. The information was correct if you squinted while reading, but
hopefully switching the order of the registers as listed conveys it
better.

Cc: Johnny Huang <johnny_huang@aspeedtech.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Acked-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20190628023838.15426-7-andrew@aj.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed.c

index eb87ab774269c5ea73e63c2c12af62f9499b51a3..89cf61b764cbce906fa768faa17a8a82f26c488c 100644 (file)
@@ -213,7 +213,7 @@ static int aspeed_sig_expr_set(const struct aspeed_sig_expr *expr,
                if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP2)
                        continue;
 
-               /* On AST2500, Set bits in SCU7C are cleared from SCU70 */
+               /* On AST2500, Set bits in SCU70 are cleared from SCU7C */
                if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP1) {
                        unsigned int rev_id;