ACPI: event: replace strcpy() by strscpy()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 22 Apr 2019 16:39:34 +0000 (11:39 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 23 Apr 2019 08:54:26 +0000 (10:54 +0200)
The strcpy() function is being deprecated. Replace it by the safer
strscpy() and fix the following Coverity warnings:

"You might overrun the 15-character fixed-size string event->bus_id
by copying bus_id without checking the length."

"You might overrun the 20-character fixed-size string event->device_class
by copying device_class without checking the length."

Addresses-Coverity-ID: 139001 ("Copy into fixed size buffer")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/event.c

index 5a127f3f2d5c3a912998611a04f1ec5813bd5ba6..47f21599f2ab59aabc05731a6e90a94f566a56eb 100644 (file)
@@ -131,8 +131,8 @@ int acpi_bus_generate_netlink_event(const char *device_class,
        event = nla_data(attr);
        memset(event, 0, sizeof(struct acpi_genl_event));
 
-       strcpy(event->device_class, device_class);
-       strcpy(event->bus_id, bus_id);
+       strscpy(event->device_class, device_class, sizeof(event->device_class));
+       strscpy(event->bus_id, bus_id, sizeof(event->bus_id));
        event->type = type;
        event->data = data;