bonding: remove the redundant judgements for bond_option_queue_id_set()
authordingtianhong <dingtianhong@huawei.com>
Wed, 12 Feb 2014 06:58:50 +0000 (14:58 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Feb 2014 22:49:13 +0000 (17:49 -0500)
The dev_valid_name() will check the buffer length for input name, no need to
check it twice.

Cc: Jay Vosburgh <fubar@us.ibm.com>
Cc: Veaceslav Falico <vfalico@redhat.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_options.c

index 11cb943222d5c839ed363715db445351e6b3da56..832d6e90b1b9d56bf8b36d1295ed97c7b80d692d 100644 (file)
@@ -1199,8 +1199,7 @@ int bond_option_queue_id_set(struct bonding *bond,
                goto err_no_cmd;
 
        /* Check buffer length, valid ifname and queue id */
-       if (strlen(newval->string) > IFNAMSIZ ||
-           !dev_valid_name(newval->string) ||
+       if (!dev_valid_name(newval->string) ||
            qid > bond->dev->real_num_tx_queues)
                goto err_no_cmd;