xfs: remove [cm]time update from reflink calls
authorDarrick J. Wong <darrick.wong@oracle.com>
Mon, 29 Oct 2018 23:47:48 +0000 (10:47 +1100)
committerDave Chinner <david@fromorbit.com>
Mon, 29 Oct 2018 23:47:48 +0000 (10:47 +1100)
Now that the vfs remap helper dirties the inode [cm]time for us, xfs no
longer needs to do that on its own.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_reflink.c

index 84f372f7ea044864e917b3b9e1941990539807c5..e72218477bf2dc3ff92fdfaa32979d535d701142 100644 (file)
@@ -927,8 +927,7 @@ xfs_reflink_update_dest(
        struct xfs_trans        *tp;
        int                     error;
 
-       if ((remap_flags & REMAP_FILE_DEDUP) &&
-           newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0)
+       if (newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0)
                return 0;
 
        error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp);
@@ -949,10 +948,6 @@ xfs_reflink_update_dest(
                dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE;
        }
 
-       if (!(remap_flags & REMAP_FILE_DEDUP)) {
-               xfs_trans_ichgtime(tp, dest,
-                                  XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
-       }
        xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE);
 
        error = xfs_trans_commit(tp);