spi: pic32: remove unnecessary of_node_get()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Thu, 6 Sep 2018 22:16:54 +0000 (01:16 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 7 Sep 2018 16:04:51 +0000 (17:04 +0100)
Almost all spi drivers assign spi master->dev.of_node from
its parent platform device without additional refcounting.
It seems of_node_get() in pic32_spi_probe() is unnecessary
and there is no corresponding of_node_put().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pic32.c

index f8a45af1fa9f2434689b7946435d26859f895306..46ff76193ee15f01950d5e21e5d4d21ca0d67423 100644 (file)
@@ -774,7 +774,7 @@ static int pic32_spi_probe(struct platform_device *pdev)
        if (ret)
                goto err_master;
 
-       master->dev.of_node     = of_node_get(pdev->dev.of_node);
+       master->dev.of_node     = pdev->dev.of_node;
        master->mode_bits       = SPI_MODE_3 | SPI_MODE_0 | SPI_CS_HIGH;
        master->num_chipselect  = 1; /* single chip-select */
        master->max_speed_hz    = clk_get_rate(pic32s->clk);