swiotlb: remove SWIOTLB_MAP_ERROR
authorChristoph Hellwig <hch@lst.de>
Mon, 3 Dec 2018 10:42:52 +0000 (11:42 +0100)
committerChristoph Hellwig <hch@lst.de>
Thu, 13 Dec 2018 20:06:13 +0000 (21:06 +0100)
We can use DMA_MAPPING_ERROR instead, which already maps to the same
value.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Tony Luck <tony.luck@intel.com>
drivers/xen/swiotlb-xen.c
include/linux/swiotlb.h
kernel/dma/swiotlb.c

index 6dc969d5ea2fac328c48d16976e2a434870377ea..833e80b46eb27acbccd457465436c9996115b58e 100644 (file)
@@ -403,7 +403,7 @@ static dma_addr_t xen_swiotlb_map_page(struct device *dev, struct page *page,
 
        map = swiotlb_tbl_map_single(dev, start_dma_addr, phys, size, dir,
                                     attrs);
-       if (map == SWIOTLB_MAP_ERROR)
+       if (map == DMA_MAPPING_ERROR)
                return DMA_MAPPING_ERROR;
 
        dev_addr = xen_phys_to_bus(map);
@@ -572,7 +572,7 @@ xen_swiotlb_map_sg_attrs(struct device *hwdev, struct scatterlist *sgl,
                                                                 sg_phys(sg),
                                                                 sg->length,
                                                                 dir, attrs);
-                       if (map == SWIOTLB_MAP_ERROR) {
+                       if (map == DMA_MAPPING_ERROR) {
                                dev_warn(hwdev, "swiotlb buffer is full\n");
                                /* Don't panic here, we expect map_sg users
                                   to do proper error handling. */
index a387b59640a4b0d7a6edea41ad58205d74042d89..14aec0b70dd94749ab671727081da4952bf4399b 100644 (file)
@@ -46,9 +46,6 @@ enum dma_sync_target {
        SYNC_FOR_DEVICE = 1,
 };
 
-/* define the last possible byte of physical address space as a mapping error */
-#define SWIOTLB_MAP_ERROR (~(phys_addr_t)0x0)
-
 extern phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
                                          dma_addr_t tbl_dma_addr,
                                          phys_addr_t phys, size_t size,
index ff1ce81bb62344ba600613a7394dfab782b0a7c8..19ba8e473d71c53869bcffe6f40d65d2f4f9a1d6 100644 (file)
@@ -526,7 +526,7 @@ not_found:
        spin_unlock_irqrestore(&io_tlb_lock, flags);
        if (!(attrs & DMA_ATTR_NO_WARN) && printk_ratelimit())
                dev_warn(hwdev, "swiotlb buffer is full (sz: %zd bytes)\n", size);
-       return SWIOTLB_MAP_ERROR;
+       return DMA_MAPPING_ERROR;
 found:
        spin_unlock_irqrestore(&io_tlb_lock, flags);
 
@@ -637,7 +637,7 @@ static dma_addr_t swiotlb_bounce_page(struct device *dev, phys_addr_t *phys,
        /* Oh well, have to allocate and map a bounce buffer. */
        *phys = swiotlb_tbl_map_single(dev, __phys_to_dma(dev, io_tlb_start),
                        *phys, size, dir, attrs);
-       if (*phys == SWIOTLB_MAP_ERROR)
+       if (*phys == DMA_MAPPING_ERROR)
                return DMA_MAPPING_ERROR;
 
        /* Ensure that the address returned is DMA'ble */