RDMA/cxgb4: Set arp error handler for PASS_ACCEPT_RPL messages
authorSteve Wise <swise@opengridcomputing.com>
Tue, 6 Aug 2013 15:34:37 +0000 (21:04 +0530)
committerRoland Dreier <roland@purestorage.com>
Tue, 13 Aug 2013 18:55:47 +0000 (11:55 -0700)
accept_cr() failed to set the arp error handler on a reused skb.  This
results in a kernel crash if the arp does indeed time out.

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Vipul Pandya <vipul@chelsio.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/cxgb4/cm.c

index 8865a3332a62897d7866b497488a10d7760782a1..12fef76c791c524454bd9a0c48d5b4a967ac19af 100644 (file)
@@ -332,6 +332,7 @@ static struct sk_buff *get_skb(struct sk_buff *skb, int len, gfp_t gfp)
        } else {
                skb = alloc_skb(len, gfp);
        }
+       t4_set_arp_err_handler(skb, NULL, NULL);
        return skb;
 }
 
@@ -2025,6 +2026,7 @@ static void accept_cr(struct c4iw_ep *ep, struct sk_buff *skb,
        rpl->opt0 = cpu_to_be64(opt0);
        rpl->opt2 = cpu_to_be32(opt2);
        set_wr_txq(skb, CPL_PRIORITY_SETUP, ep->ctrlq_idx);
+       t4_set_arp_err_handler(skb, NULL, arp_failure_discard);
        c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t);
 
        return;