iio: imu: inv_mpu6050: Fix Yoda conditions
authorDaniel Baluta <daniel.baluta@intel.com>
Thu, 18 Feb 2016 15:53:07 +0000 (17:53 +0200)
committerJonathan Cameron <jic23@kernel.org>
Wed, 24 Feb 2016 20:40:42 +0000 (20:40 +0000)
This fixes the following checkpatch warning:
* WARNING: Comparisons should place the constant
  on the right side of the test

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Acked-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c

index 84e014cc67c3bd56ed84f114e24c11b1460d1a9c..c550ebb19ee664ab615b3f214ca2dceca8b89c39 100644 (file)
@@ -84,7 +84,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
         * clock source be switched to gyro. Otherwise, it must be set to
         * internal clock
         */
-       if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
+       if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
                result = regmap_read(st->map, st->reg->pwr_mgmt_1, &mgmt_1);
                if (result)
                        return result;
@@ -92,7 +92,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
                mgmt_1 &= ~INV_MPU6050_BIT_CLK_MASK;
        }
 
-       if ((INV_MPU6050_BIT_PWR_GYRO_STBY == mask) && (!en)) {
+       if ((mask == INV_MPU6050_BIT_PWR_GYRO_STBY) && (!en)) {
                /*
                 * turning off gyro requires switch to internal clock first.
                 * Then turn off gyro engine
@@ -117,7 +117,7 @@ int inv_mpu6050_switch_engine(struct inv_mpu6050_state *st, bool en, u32 mask)
        if (en) {
                /* Wait for output stabilize */
                msleep(INV_MPU6050_TEMP_UP_TIME);
-               if (INV_MPU6050_BIT_PWR_GYRO_STBY == mask) {
+               if (mask == INV_MPU6050_BIT_PWR_GYRO_STBY) {
                        /* switch internal clock to PLL */
                        mgmt_1 |= INV_CLK_PLL;
                        result = regmap_write(st->map,
index 1fc5fd96bb0098c61bbad1601469d56c414d1cf3..441080b81f00a6fd5242060710f04c6ca838920a 100644 (file)
@@ -168,7 +168,7 @@ irqreturn_t inv_mpu6050_read_fifo(int irq, void *p)
 
                result = kfifo_out(&st->timestamps, &timestamp, 1);
                /* when there is no timestamp, put timestamp as 0 */
-               if (0 == result)
+               if (result == 0)
                        timestamp = 0;
 
                result = iio_push_to_buffers_with_timestamp(indio_dev, data,