f2fs: fix to add missing iput() in gc_data_segment()

During gc_data_segment(), if inode state is abnormal, it missed to call
iput(), fix it.

Fixes: b73e52824c89 ("f2fs: reposition unlock_new_inode to prevent accessing invalid inode")
Fixes: 9056d6489f5a ("f2fs: fix to do sanity check on inode type during garbage collection")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index ac4cbbe50c2fc4bd3392665e75e3bc354d3fb416..6066c6eecf41d26c3c21dffa63d3cd4c1152af73 100644 (file)
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1554,10 +1554,15 @@ next_step:
                        int err;
 
                        inode = f2fs_iget(sb, dni.ino);
-                       if (IS_ERR(inode) || is_bad_inode(inode) ||
-                                       special_file(inode->i_mode))
+                       if (IS_ERR(inode))
                                continue;
 
+                       if (is_bad_inode(inode) ||
+                                       special_file(inode->i_mode)) {
+                               iput(inode);
+                               continue;
+                       }
+
                        err = f2fs_gc_pinned_control(inode, gc_type, segno);
                        if (err == -EAGAIN) {
                                iput(inode);