drm/amd/display: Replace for loop w/ function call
authorWesley Chalmers <Wesley.Chalmers@amd.com>
Wed, 21 Aug 2019 20:09:27 +0000 (16:09 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Sep 2019 13:06:54 +0000 (08:06 -0500)
[WHY]
A function to adjust DPP clocks with DTO already exists; function code
is identical to the code replaced here

Signed-off-by: Wesley Chalmers <Wesley.Chalmers@amd.com>
Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c

index 3e8ac303bd526823c978592f3bcf8838669a3a0b..f1df32664414195dde9f373c5fbc833492aab5bb 100644 (file)
@@ -196,7 +196,6 @@ void dcn2_update_clocks(struct clk_mgr *clk_mgr_base,
        bool enter_display_off = false;
        struct dmcu *dmcu = clk_mgr_base->ctx->dc->res_pool->dmcu;
        bool force_reset = false;
-       int i;
 
        if (dc->work_arounds.skip_clock_update)
                return;
@@ -278,34 +277,14 @@ void dcn2_update_clocks(struct clk_mgr *clk_mgr_base,
                                request_voltage_and_program_global_dpp_clk(clk_mgr_base, new_clocks->dppclk_khz);
 
                        // Then raise any dividers that need raising
-                       for (i = 0; i < clk_mgr->base.ctx->dc->res_pool->pipe_count; i++) {
-                               int dpp_inst, dppclk_khz;
-
-                               if (!context->res_ctx.pipe_ctx[i].plane_state)
-                                       continue;
-
-                               dpp_inst = context->res_ctx.pipe_ctx[i].plane_res.dpp->inst;
-                               dppclk_khz = context->res_ctx.pipe_ctx[i].plane_res.bw.dppclk_khz;
-
-                               clk_mgr->dccg->funcs->update_dpp_dto(clk_mgr->dccg, dpp_inst, dppclk_khz, true);
-                       }
+                       dcn20_update_clocks_update_dpp_dto(clk_mgr, context);
                } else {
                        // For post-programming, we can lower ref clk if needed, and unconditionally set all the DTOs
 
                        if (new_clocks->dppclk_khz < clk_mgr_base->clks.dppclk_khz)
                                request_voltage_and_program_global_dpp_clk(clk_mgr_base, new_clocks->dppclk_khz);
+                       dcn20_update_clocks_update_dpp_dto(clk_mgr, context);
 
-                       for (i = 0; i < clk_mgr->base.ctx->dc->res_pool->pipe_count; i++) {
-                               int dpp_inst, dppclk_khz;
-
-                               if (!context->res_ctx.pipe_ctx[i].plane_state)
-                                       continue;
-
-                               dpp_inst = context->res_ctx.pipe_ctx[i].plane_res.dpp->inst;
-                               dppclk_khz = context->res_ctx.pipe_ctx[i].plane_res.bw.dppclk_khz;
-
-                               clk_mgr->dccg->funcs->update_dpp_dto(clk_mgr->dccg, dpp_inst, dppclk_khz, false);
-                       }
                }
        }
        if (update_dispclk &&