iio: ad9523: Fix return value for ad952x_store()
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 27 Jul 2018 06:42:45 +0000 (09:42 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 28 Jul 2018 09:35:34 +0000 (10:35 +0100)
A sysfs write callback function needs to either return the number of
consumed characters or an error.

The ad952x_store() function currently returns 0 if the input value was "0",
this will signal that no characters have been consumed and the function
will be called repeatedly in a loop indefinitely. Fix this by returning
number of supplied characters to indicate that the whole input string has
been consumed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Fixes: cd1678f96329 ("iio: frequency: New driver for AD9523 SPI Low Jitter Clock Generator")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/frequency/ad9523.c

index 37504739c27797630d692eb74a773a6887d6c64c..059b2fda8cbd8056e602db498a76c198b5ef78bf 100644 (file)
@@ -518,7 +518,7 @@ static ssize_t ad9523_store(struct device *dev,
                return ret;
 
        if (!state)
-               return 0;
+               return len;
 
        mutex_lock(&st->lock);
        switch ((u32)this_attr->address) {