rt2x00pci: Use PCI MSIs whenever possible
authorJakub Kicinski <kubakici@wp.pl>
Mon, 6 May 2013 22:28:50 +0000 (00:28 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 22 May 2013 19:05:32 +0000 (15:05 -0400)
All PCIe devices must support MSIs, make use of them.

Signed-off-by: Jakub Kicinski <kubakici@wp.pl>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00pci.c

index dc49e525ae5e55e9a090308b80122998e08857d8..76d95deb274be56feb9803adb5b8d198f0c35bd0 100644 (file)
@@ -105,11 +105,13 @@ int rt2x00pci_probe(struct pci_dev *pci_dev, const struct rt2x00_ops *ops)
                goto exit_release_regions;
        }
 
+       pci_enable_msi(pci_dev);
+
        hw = ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw);
        if (!hw) {
                rt2x00_probe_err("Failed to allocate hardware\n");
                retval = -ENOMEM;
-               goto exit_release_regions;
+               goto exit_disable_msi;
        }
 
        pci_set_drvdata(pci_dev, hw);
@@ -150,6 +152,9 @@ exit_free_reg:
 exit_free_device:
        ieee80211_free_hw(hw);
 
+exit_disable_msi:
+       pci_disable_msi(pci_dev);
+
 exit_release_regions:
        pci_release_regions(pci_dev);
 
@@ -174,6 +179,8 @@ void rt2x00pci_remove(struct pci_dev *pci_dev)
        rt2x00pci_free_reg(rt2x00dev);
        ieee80211_free_hw(hw);
 
+       pci_disable_msi(pci_dev);
+
        /*
         * Free the PCI device data.
         */