RDMA/uverbs: fix ptr_ret.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Tue, 27 Nov 2018 23:21:30 +0000 (07:21 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 29 Nov 2018 22:59:40 +0000 (15:59 -0700)
drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on success")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/uverbs_cmd.c

index 8ee9e94e25fe54df63b47a1b368fd3ba574536b9..dc06b6914b5e76ea20a1a58e266d1d341bf79b22 100644 (file)
@@ -1050,11 +1050,7 @@ static int ib_uverbs_create_cq(struct uverbs_attr_bundle *attrs,
                        offsetof(typeof(cmd_ex), comp_channel) +
                                sizeof(cmd.comp_channel),
                        ib_uverbs_create_cq_cb, NULL);
-
-       if (IS_ERR(obj))
-               return PTR_ERR(obj);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(obj);
 }
 
 static int ib_uverbs_ex_create_cq_cb(struct uverbs_attr_bundle *attrs,