watchdog: gpio: Do not use device pointer from struct watchdog_device
authorGuenter Roeck <linux@roeck-us.net>
Thu, 24 Dec 2015 22:22:02 +0000 (14:22 -0800)
committerWim Van Sebroeck <wim@iguana.be>
Mon, 28 Dec 2015 22:04:05 +0000 (23:04 +0100)
The device pointer in struct watchdog_device has a different lifetime
than the driver code and should not be used in drivers. Use the pointer
to the parent device instead.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/gpio_wdt.c

index 035c2387b84625033ddabc267abb81aa9d13402a..ba066e4a707beb969e51d72a22e50b51431b3d9a 100644 (file)
@@ -54,7 +54,8 @@ static void gpio_wdt_hwping(unsigned long data)
 
        if (priv->armed && time_after(jiffies, priv->last_jiffies +
                                      msecs_to_jiffies(wdd->timeout * 1000))) {
-               dev_crit(wdd->dev, "Timer expired. System will reboot soon!\n");
+               dev_crit(wdd->parent,
+                        "Timer expired. System will reboot soon!\n");
                return;
        }