ALSA: hda - Disable widget power-save for VIA codecs
authorTakashi Iwai <tiwai@suse.de>
Thu, 25 Jun 2015 06:48:54 +0000 (08:48 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 25 Jun 2015 06:48:54 +0000 (08:48 +0200)
The widget power-save that was enabled in 4.1 kernel seems resulting
in the silent output on VIA codecs by some reason.  Some widgets get
wrong power states.

As a quick fix, turn this flag off while keeping power_down_unused
flag.  This will bring back to the state of 4.0.x.

Fixes: 688b12cc3ca8 ('ALSA: hda - Use the new power control for VIA codecs')
Reported-and-tested-by: Harald Dunkel <harri@afaics.de>
Cc: <stable@vger.kernel.org> # v4.1
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_via.c

index 0521be8d46a81c08f6580e57a5a495066f22d977..da5366405eda55a6eccbca0e14bce5631c851cdc 100644 (file)
@@ -241,7 +241,9 @@ static int via_pin_power_ctl_get(struct snd_kcontrol *kcontrol,
                                 struct snd_ctl_elem_value *ucontrol)
 {
        struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
-       ucontrol->value.enumerated.item[0] = codec->power_save_node;
+       struct via_spec *spec = codec->spec;
+
+       ucontrol->value.enumerated.item[0] = spec->gen.power_down_unused;
        return 0;
 }
 
@@ -252,9 +254,9 @@ static int via_pin_power_ctl_put(struct snd_kcontrol *kcontrol,
        struct via_spec *spec = codec->spec;
        bool val = !!ucontrol->value.enumerated.item[0];
 
-       if (val == codec->power_save_node)
+       if (val == spec->gen.power_down_unused)
                return 0;
-       codec->power_save_node = val;
+       /* codec->power_save_node = val; */ /* widget PM seems yet broken */
        spec->gen.power_down_unused = val;
        analog_low_current_mode(codec);
        return 1;