ext3: fix return values on parse_options() failure
authorZhao Hongjiang <zhaohongjiang@huawei.com>
Tue, 9 Oct 2012 05:48:47 +0000 (13:48 +0800)
committerJan Kara <jack@suse.cz>
Tue, 9 Oct 2012 21:24:03 +0000 (23:24 +0200)
parse_options() in ext3 should return 0 when parse the mount options fails.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
fs/ext3/super.c

index 17ae5c83d2346353272fb0c42ed52f1a20aa3c70..ebf8312c3a4e4fec8f3143284fa9438db19af082 100644 (file)
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
                        uid = make_kuid(current_user_ns(), option);
                        if (!uid_valid(uid)) {
                                ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-                               return -1;
+                               return 0;
 
                        }
                        sbi->s_resuid = uid;
@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
                        gid = make_kgid(current_user_ns(), option);
                        if (!gid_valid(gid)) {
                                ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-                               return -1;
+                               return 0;
                        }
                        sbi->s_resgid = gid;
                        break;