SUNRPC: Remove redundant check for the reply length in call_decode()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 15 Mar 2019 17:11:36 +0000 (13:11 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 15 Mar 2019 17:11:36 +0000 (13:11 -0400)
Now that we're using the xdr_stream functions to decode the header,
the test for the minimum reply length is redundant.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/clnt.c

index cb73d6c25857ef17c3a96f119b32f4091c280a0b..228970e6e52ba8b407be724d055976dd67530f81 100644 (file)
@@ -2392,9 +2392,6 @@ call_decode(struct rpc_task *task)
        WARN_ON(memcmp(&req->rq_rcv_buf, &req->rq_private_buf,
                                sizeof(req->rq_rcv_buf)) != 0);
 
-       if (req->rq_rcv_buf.len < 12)
-               goto out_retry;
-
        xdr_init_decode(&xdr, &req->rq_rcv_buf,
                        req->rq_rcv_buf.head[0].iov_base, req);
        switch (rpc_decode_header(task, &xdr)) {
@@ -2405,7 +2402,6 @@ call_decode(struct rpc_task *task)
                        task->tk_pid, __func__, task->tk_status);
                return;
        case -EAGAIN:
-out_retry:
                task->tk_status = 0;
                /* Note: rpc_decode_header() may have freed the RPC slot */
                if (task->tk_rqstp == req) {