powerpc: Fix oops on some machines due to incorrect pr_debug()
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Sun, 1 Feb 2009 17:03:59 +0000 (17:03 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Mon, 2 Feb 2009 06:08:25 +0000 (17:08 +1100)
Recently, a patch left DEBUG enabled in the powerpc common PCI code,
resulting in an old bug in a pr_debug() statement to show up and cause
a NULL dereference on some machines.

This fixes the pr_debug() statement and reverts to DEBUG not being
force-enabled in that file.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/pci-common.c

index da5a3855a0c474c0619c8d97c07b4f494980f8b8..19b12d2cbb4ba2e97f2aaff19f32a1eb54cecc73 100644 (file)
@@ -16,8 +16,6 @@
  * 2 of the License, or (at your option) any later version.
  */
 
-#define DEBUG
-
 #include <linux/kernel.h>
 #include <linux/pci.h>
 #include <linux/string.h>
@@ -258,7 +256,8 @@ int pci_read_irq_line(struct pci_dev *pci_dev)
        } else {
                pr_debug(" Got one, spec %d cells (0x%08x 0x%08x...) on %s\n",
                         oirq.size, oirq.specifier[0], oirq.specifier[1],
-                   oirq.controller->full_name);
+                        oirq.controller ? oirq.controller->full_name :
+                        "<default>");
 
                virq = irq_create_of_mapping(oirq.controller, oirq.specifier,
                                             oirq.size);