bnx2x: fix logical op
authorRandy Dunlap <randy.dunlap@oracle.com>
Fri, 8 Aug 2008 03:33:19 +0000 (20:33 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Aug 2008 03:33:19 +0000 (20:33 -0700)
Fix dubious logical operation that was found by sparse:
linux-next-20080807/drivers/net/bnx2x_main.c:7205:27: warning: dubious: !x & y

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x_main.c

index af251a5df844929097ef67adb394936871bbec3b..272a4bd25953e3d1e91007530a507d4599a4fb2b 100644 (file)
@@ -7202,7 +7202,7 @@ static void __devinit bnx2x_link_settings_requested(struct bnx2x *bp)
        bp->link_params.req_flow_ctrl = (bp->port.link_config &
                                         PORT_FEATURE_FLOW_CONTROL_MASK);
        if ((bp->link_params.req_flow_ctrl == FLOW_CTRL_AUTO) &&
-           (!bp->port.supported & SUPPORTED_Autoneg))
+           !(bp->port.supported & SUPPORTED_Autoneg))
                bp->link_params.req_flow_ctrl = FLOW_CTRL_NONE;
 
        BNX2X_DEV_INFO("req_line_speed %d  req_duplex %d  req_flow_ctrl 0x%x"