watchdog: smsc37b787_wdt: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 14 Feb 2019 20:16:01 +0000 (14:16 -0600)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 2 Mar 2019 14:28:21 +0000 (15:28 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/watchdog/smsc37b787_wdt.c: In function ‘wb_smsc_wdt_ioctl’:
drivers/watchdog/smsc37b787_wdt.c:480:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   wb_smsc_wdt_set_timeout(timeout);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/watchdog/smsc37b787_wdt.c:482:2: note: here
  case WDIOC_GETTIMEOUT:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/smsc37b787_wdt.c

index 445ea1ad1fa9abc7fcef53b63e5d0025032f9f07..c768dcd5303484120ecae579da9cc08ddc8f1e74 100644 (file)
@@ -478,7 +478,7 @@ static long wb_smsc_wdt_ioctl(struct file *file,
                        return -EINVAL;
                timeout = new_timeout;
                wb_smsc_wdt_set_timeout(timeout);
-               /* fall through and return the new timeout... */
+               /* fall through and return the new timeout... */
        case WDIOC_GETTIMEOUT:
                new_timeout = timeout;
                if (unit == UNIT_MINUTE)