spi: oc-tiny: Use of_property_read_u32 instead of open-coding it
authorTobias Klauser <tklauser@distanz.ch>
Wed, 9 Sep 2015 11:55:53 +0000 (13:55 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 16 Sep 2015 18:16:01 +0000 (19:16 +0100)
Use of_property_read_u32 instead of of_get_property with return value
checks and endianness conversion.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-oc-tiny.c

index 76656a77ec1213d1db70d6ee98d546bc0f760da9..b5911282a61116c47b0237071df40261831f94ab 100644 (file)
@@ -207,8 +207,7 @@ static int tiny_spi_of_probe(struct platform_device *pdev)
        struct tiny_spi *hw = platform_get_drvdata(pdev);
        struct device_node *np = pdev->dev.of_node;
        unsigned int i;
-       const __be32 *val;
-       int len;
+       u32 val;
 
        if (!np)
                return 0;
@@ -226,13 +225,10 @@ static int tiny_spi_of_probe(struct platform_device *pdev)
                        return -ENODEV;
        }
        hw->bitbang.master->dev.of_node = pdev->dev.of_node;
-       val = of_get_property(pdev->dev.of_node,
-                             "clock-frequency", &len);
-       if (val && len >= sizeof(__be32))
-               hw->freq = be32_to_cpup(val);
-       val = of_get_property(pdev->dev.of_node, "baud-width", &len);
-       if (val && len >= sizeof(__be32))
-               hw->baudwidth = be32_to_cpup(val);
+       if (!of_property_read_u32(np, "clock-frequency", &val))
+               hw->freq = val;
+       if (!of_property_read_u32(np, "baud-width", &val))
+               hw->baudwidth = val;
        return 0;
 }
 #else /* !CONFIG_OF */