Staging: fsl-mc: Replace pr_err with dev_err
authorBhumika Goyal <bhumirks@gmail.com>
Fri, 4 Mar 2016 13:45:55 +0000 (19:15 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
This patch replaces pr_err calls with dev_err when the device structure
is available as dev_* prints identifying information about the struct device.
Done using coccinelle:

@r exists@
identifier f, s;
identifier x;
position p;
@@
f(...,struct s *x,...) {
<+...
when != x == NULL
\(pr_err@p\|pr_debug@p\|pr_info\)(...);
...+>
}

@r2@
identifier fld2;
identifier r.s;
@@

struct s {
        ...
        struct device *fld2;
        ...
};

@@
identifier r.x,r2.fld2;
position r.p;
@@

(
-pr_err@p
+dev_err
   (
+ &x->fld2,
...)
|
- pr_debug@p
+ dev_dbg
   (
+ &x->fld2,
...)
|
- pr_info@p
+ dev_info
   (
+ &x->fld2,
...)
)

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/mc-bus.c

index 5958e0fd0025d60b34c68e967a278eb3e5ff75a1..9f77c37bd612f74539588939fc19b5e0357bc351 100644 (file)
@@ -260,14 +260,15 @@ static int get_dprc_icid(struct fsl_mc_io *mc_io,
 
        error = dprc_open(mc_io, 0, container_id, &dprc_handle);
        if (error < 0) {
-               pr_err("dprc_open() failed: %d\n", error);
+               dev_err(&mc_io->dev, "dprc_open() failed: %d\n", error);
                return error;
        }
 
        memset(&attr, 0, sizeof(attr));
        error = dprc_get_attributes(mc_io, 0, dprc_handle, &attr);
        if (error < 0) {
-               pr_err("dprc_get_attributes() failed: %d\n", error);
+               dev_err(&mc_io->dev, "dprc_get_attributes() failed: %d\n",
+                       error);
                goto common_cleanup;
        }