btrfs: use bool argument in free_root_pointers()
authorAnand Jain <anand.jain@oracle.com>
Thu, 10 Oct 2019 02:39:25 +0000 (10:39 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 18 Nov 2019 11:46:55 +0000 (12:46 +0100)
We don't need int argument bool shall do in free_root_pointers().  And
rename the argument as it confused two people.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c

index 43e14a17e3f4fd083f59a787381e0ce79ed2eca8..5d32deb429936cdb9e65481a612e514137546b38 100644 (file)
@@ -2022,7 +2022,7 @@ static void free_root_extent_buffers(struct btrfs_root *root)
 }
 
 /* helper to cleanup tree roots */
-static void free_root_pointers(struct btrfs_fs_info *info, int chunk_root)
+static void free_root_pointers(struct btrfs_fs_info *info, bool free_chunk_root)
 {
        free_root_extent_buffers(info->tree_root);
 
@@ -2031,7 +2031,7 @@ static void free_root_pointers(struct btrfs_fs_info *info, int chunk_root)
        free_root_extent_buffers(info->csum_root);
        free_root_extent_buffers(info->quota_root);
        free_root_extent_buffers(info->uuid_root);
-       if (chunk_root)
+       if (free_chunk_root)
                free_root_extent_buffers(info->chunk_root);
        free_root_extent_buffers(info->free_space_root);
 }
@@ -3320,7 +3320,7 @@ fail_block_groups:
        btrfs_put_block_group_cache(fs_info);
 
 fail_tree_roots:
-       free_root_pointers(fs_info, 1);
+       free_root_pointers(fs_info, true);
        invalidate_inode_pages2(fs_info->btree_inode->i_mapping);
 
 fail_sb_buffer:
@@ -3352,7 +3352,7 @@ recovery_tree_root:
        if (!btrfs_test_opt(fs_info, USEBACKUPROOT))
                goto fail_tree_roots;
 
-       free_root_pointers(fs_info, 0);
+       free_root_pointers(fs_info, false);
 
        /* don't use the log in recovery mode, it won't be valid */
        btrfs_set_super_log_root(disk_super, 0);
@@ -4046,7 +4046,7 @@ void __cold close_ctree(struct btrfs_fs_info *fs_info)
        btrfs_free_block_groups(fs_info);
 
        clear_bit(BTRFS_FS_OPEN, &fs_info->flags);
-       free_root_pointers(fs_info, 1);
+       free_root_pointers(fs_info, true);
 
        iput(fs_info->btree_inode);