rtl8xxxu: fix uninitialized return value in ret
authorColin Ian King <colin.king@canonical.com>
Thu, 14 Apr 2016 20:37:07 +0000 (16:37 -0400)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 15 Apr 2016 18:38:03 +0000 (21:38 +0300)
several functions are not initializing a return status in ret
resulting in garbage to be returned instead of 0 for success.
Currently, the calls to these functions are not checking the
return, however, it seems prudent to return the correct status
in case they are to be checked at a later date.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c

index 037b64f7bea4143f1bc1decf13a860036d564ca8..b88cf163148928d78c3b1ff7d4c2ca26d629bc5e 100644 (file)
@@ -6370,7 +6370,7 @@ static void rtl8xxxu_set_ampdu_min_space(struct rtl8xxxu_priv *priv, u8 density)
 static int rtl8xxxu_active_to_emu(struct rtl8xxxu_priv *priv)
 {
        u8 val8;
-       int count, ret;
+       int count, ret = 0;
 
        /* Start of rtl8723AU_card_enable_flow */
        /* Act to Cardemu sequence*/
@@ -6420,7 +6420,7 @@ static int rtl8723bu_active_to_emu(struct rtl8xxxu_priv *priv)
        u8 val8;
        u16 val16;
        u32 val32;
-       int count, ret;
+       int count, ret = 0;
 
        /* Turn off RF */
        rtl8xxxu_write8(priv, REG_RF_CTRL, 0);
@@ -6477,7 +6477,7 @@ static int rtl8xxxu_active_to_lps(struct rtl8xxxu_priv *priv)
 {
        u8 val8;
        u8 val32;
-       int count, ret;
+       int count, ret = 0;
 
        rtl8xxxu_write8(priv, REG_TXPAUSE, 0xff);