drm/i915/tgl: Add extra hdc flush workaround
authorMika Kuoppala <mika.kuoppala@linux.intel.com>
Tue, 15 Oct 2019 15:44:42 +0000 (18:44 +0300)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 15 Oct 2019 17:16:51 +0000 (18:16 +0100)
In order to ensure constant caches are invalidated
properly with a0, we need extra hdc flush after invalidation.

v2: use IS_TGL_REVID (Chris)

References: HSDES#1604544889
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-4-mika.kuoppala@linux.intel.com
drivers/gpu/drm/i915/gt/intel_lrc.c

index d1b10f00d72938c2d395524ab205e7a7e8ef66f4..62d5ece95c9de5062e8f4a992988d1a95a2a0586 100644 (file)
@@ -3253,6 +3253,26 @@ static int gen12_emit_flush_render(struct i915_request *request,
 
                *cs++ = preparser_disable(false);
                intel_ring_advance(request, cs);
+
+               /*
+                * Wa_1604544889:tgl
+                */
+               if (IS_TGL_REVID(request->i915, TGL_REVID_A0, TGL_REVID_A0)) {
+                       flags = 0;
+                       flags |= PIPE_CONTROL_CS_STALL;
+                       flags |= PIPE_CONTROL_HDC_PIPELINE_FLUSH;
+
+                       flags |= PIPE_CONTROL_STORE_DATA_INDEX;
+                       flags |= PIPE_CONTROL_QW_WRITE;
+
+                       cs = intel_ring_begin(request, 6);
+                       if (IS_ERR(cs))
+                               return PTR_ERR(cs);
+
+                       cs = gen8_emit_pipe_control(cs, flags,
+                                                   LRC_PPHWSP_SCRATCH_ADDR);
+                       intel_ring_advance(request, cs);
+               }
        }
 
        return 0;