btrfs: ctree: Remove stray comment of setting up path lock
authorQu Wenruo <wqu@suse.com>
Tue, 10 Sep 2019 07:40:19 +0000 (15:40 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 18 Nov 2019 11:46:46 +0000 (12:46 +0100)
The following comment shows up in btrfs_search_slot() with out much
sense:

/*
 * setup the path here so we can release it under lock
 * contention with the cow code
 */
if (cow) {
/* code touching path->lock[] is far away from here */
}

This comment hasn't been cleaned up after the relevant code has been
removed.

The original code is introduced in commit 65b51a009e29
("btrfs_search_slot: reduce lock contention by cowing in two stages"):

  +
  +               /*
  +                * setup the path here so we can release it under lock
  +                * contention with the cow code
  +                */
  +               p->nodes[level] = b;
  +               if (!p->skip_locking)
  +                       p->locks[level] = 1;
  +

But in current code, we have different timing for modifying path lock,
so just remove the comment.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c

index 42ca326a0e6b915127d9f570b570d3e7ec7e07da..0231141de289f98515e69f00644fd7895ad7eb95 100644 (file)
@@ -2789,10 +2789,6 @@ again:
 
                level = btrfs_header_level(b);
 
-               /*
-                * setup the path here so we can release it under lock
-                * contention with the cow code
-                */
                if (cow) {
                        bool last_level = (level == (BTRFS_MAX_LEVEL - 1));