dm block manager: cleanup code that prints stacktrace
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 24 Nov 2015 00:12:05 +0000 (19:12 -0500)
committerMike Snitzer <snitzer@redhat.com>
Thu, 10 Dec 2015 15:38:56 +0000 (10:38 -0500)
There is no need to record stack trace and immediately print it.  Just
use dump_stack() to print the current stack.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/persistent-data/dm-block-manager.c

index f2393ba838eb57cfa977228da492814d7dda42af..1e33dd51c21ff766418a30c8f44cff6846a92f55 100644 (file)
@@ -97,10 +97,6 @@ static void __del_holder(struct block_lock *lock, struct task_struct *task)
 static int __check_holder(struct block_lock *lock)
 {
        unsigned i;
-#ifdef CONFIG_DM_DEBUG_BLOCK_STACK_TRACING
-       static struct stack_trace t;
-       static stack_entries entries;
-#endif
 
        for (i = 0; i < MAX_HOLDERS; i++) {
                if (lock->holders[i] == current) {
@@ -110,12 +106,7 @@ static int __check_holder(struct block_lock *lock)
                        print_stack_trace(lock->traces + i, 4);
 
                        DMERR("subsequent acquisition attempted here:");
-                       t.nr_entries = 0;
-                       t.max_entries = MAX_STACK;
-                       t.entries = entries;
-                       t.skip = 3;
-                       save_stack_trace(&t);
-                       print_stack_trace(&t, 4);
+                       dump_stack();
 #endif
                        return -EINVAL;
                }