kvm: nVMX: small cleanup in handle_exception
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 6 Jun 2019 12:57:25 +0000 (14:57 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 18 Jun 2019 09:46:01 +0000 (11:46 +0200)
The reason for skipping handling of NMI and #MC in handle_exception is
the same, namely they are handled earlier by vmx_complete_atomic_exit.
Calling the machine check handler (which just returns 1) is misleading,
don't do it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx/vmx.c

index 1b3ca0582a0c824330481e78cdf87873692a703a..da6c829bad9f72ada03a8b224e40789f2543893d 100644 (file)
@@ -4455,11 +4455,8 @@ static int handle_exception(struct kvm_vcpu *vcpu)
        vect_info = vmx->idt_vectoring_info;
        intr_info = vmx->exit_intr_info;
 
-       if (is_machine_check(intr_info))
-               return handle_machine_check(vcpu);
-
-       if (is_nmi(intr_info))
-               return 1;  /* already handled by vmx_vcpu_run() */
+       if (is_machine_check(intr_info) || is_nmi(intr_info))
+               return 1;  /* already handled by vmx_complete_atomic_exit */
 
        if (is_invalid_opcode(intr_info))
                return handle_ud(vcpu);