mm: mempolicy: skip inaccessible VMAs when setting MPOL_MF_LAZY
authorMel Gorman <mgorman@suse.de>
Thu, 9 Oct 2014 22:29:36 +0000 (15:29 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Oct 2014 02:26:02 +0000 (22:26 -0400)
PROT_NUMA VMAs are skipped to avoid problems distinguishing between
present, prot_none and special entries.  MPOL_MF_LAZY is not visible from
userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
same way task_numa_work does.

Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/mempolicy.c

index 008fb32936ebfbc99ff737ff66ff177243c8a930..e58725aff7e999aeecde0e332960c498aa786128 100644 (file)
@@ -681,7 +681,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
                }
 
                if (flags & MPOL_MF_LAZY) {
-                       change_prot_numa(vma, start, endvma);
+                       /* Similar to task_numa_work, skip inaccessible VMAs */
+                       if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+                               change_prot_numa(vma, start, endvma);
                        goto next;
                }