crypto: xor - Fix warning when XOR_SELECT_TEMPLATE is unset
authorHerbert Xu <herbert@gondor.apana.org.au>
Fri, 26 Aug 2016 15:19:39 +0000 (23:19 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 31 Aug 2016 15:00:48 +0000 (23:00 +0800)
This patch fixes an unused label warning triggered when the macro
XOR_SELECT_TEMPLATE is not set.

Fixes: 39457acda913 ("crypto: xor - skip speed test if the xor...")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/xor.c

index b8975d92cd942220f8c2467ab1123c0866a38b39..263af9fb45ea281c94c41d5698d4d264d489bba9 100644 (file)
 #include <linux/preempt.h>
 #include <asm/xor.h>
 
+#ifndef XOR_SELECT_TEMPLATE
+#define XOR_SELECT_TEMPLATE(x) (x)
+#endif
+
 /* The xor routines to use.  */
 static struct xor_block_template *active_template;
 
@@ -109,17 +113,14 @@ calibrate_xor_blocks(void)
        void *b1, *b2;
        struct xor_block_template *f, *fastest;
 
-       fastest = NULL;
+       fastest = XOR_SELECT_TEMPLATE(NULL);
 
-#ifdef XOR_SELECT_TEMPLATE
-       fastest = XOR_SELECT_TEMPLATE(fastest);
        if (fastest) {
                printk(KERN_INFO "xor: automatically using best "
                                 "checksumming function   %-10s\n",
                       fastest->name);
                goto out;
        }
-#endif
 
        /*
         * Note: Since the memory is not actually used for _anything_ but to