nvme: add proper discard setup for the multipath device
authorChristoph Hellwig <hch@lst.de>
Wed, 13 Mar 2019 17:55:07 +0000 (18:55 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 13 Mar 2019 18:57:34 +0000 (12:57 -0600)
Add a gendisk argument to nvme_config_discard so that the call to
nvme_update_disk_info for the multipath device node updates the
proper request_queue.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Tested-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/core.c

index 26ae805fc9587f1c04c3fc02fedf36c394c5e008..6a57ece7d76baf09c3a937c071c281ae1164c588 100644 (file)
@@ -1495,10 +1495,10 @@ static void nvme_set_chunk_size(struct nvme_ns *ns)
        blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(chunk_size));
 }
 
-static void nvme_config_discard(struct nvme_ns *ns)
+static void nvme_config_discard(struct gendisk *disk, struct nvme_ns *ns)
 {
        struct nvme_ctrl *ctrl = ns->ctrl;
-       struct request_queue *queue = ns->queue;
+       struct request_queue *queue = disk->queue;
        u32 size = queue_logical_block_size(queue);
 
        if (!(ctrl->oncs & NVME_CTRL_ONCS_DSM)) {
@@ -1606,7 +1606,7 @@ static void nvme_update_disk_info(struct gendisk *disk,
 
        set_capacity(disk, capacity);
 
-       nvme_config_discard(ns);
+       nvme_config_discard(disk, ns);
        nvme_config_write_zeroes(ns);
 
        if (id->nsattr & (1 << 0))