isofs check for NULL ->i_op in root directory is dead code
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 4 Dec 2008 14:57:25 +0000 (09:57 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 5 Jan 2009 16:53:38 +0000 (11:53 -0500)
for one thing it never happens, for another we check that inode
is a directory right after that place anyway (and we'd already
checked that reading it from disk has not failed).

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/isofs/inode.c

index 3f8af0f1505b8d65bab47437a9fe707cfd8be4b1..6147ec3643a0ebd6280c478f0032fd8a0f051cd4 100644 (file)
@@ -855,10 +855,6 @@ root_found:
        }
        sbi->s_joliet_level = joliet_level;
 
-       /* check the root inode */
-       if (!inode->i_op)
-               goto out_bad_root;
-
        /* Make sure the root inode is a directory */
        if (!S_ISDIR(inode->i_mode)) {
                printk(KERN_WARNING
@@ -886,8 +882,6 @@ root_found:
        /*
         * Display error messages and free resources.
         */
-out_bad_root:
-       printk(KERN_WARNING "%s: root inode not initialized\n", __func__);
 out_iput:
        iput(inode);
        goto out_no_inode;