Staging: rt2860: test off by one in RtmpAsicSendCommandToMcu()
authorRoel Kluin <roel.kluin@gmail.com>
Sat, 26 Dec 2009 19:00:47 +0000 (20:00 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 4 Mar 2010 00:42:34 +0000 (16:42 -0800)
`i' reaches 101 after the loop, so if it was 100 then it succeeded in
the last iteration. This is probably unlikely to cause problems.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/rt2860/common/rtmp_mcu.c

index 9f03901433bbddb05c756ca4a2db9666ca2c0b38..e80f587cff1ade002574b9d982cd240809c25cc5 100644 (file)
@@ -221,7 +221,7 @@ int RtmpAsicSendCommandToMcu(struct rt_rtmp_adapter *pAd,
                                 ("AsicSendCommanToMcu::Mail box is busy\n"));
                } while (i++ < 100);
 
-               if (i >= 100) {
+               if (i > 100) {
                        DBGPRINT_ERR(("H2M_MAILBOX still hold by MCU. command fail\n"));
                        return FALSE;
                }