media: dvb-frontends/dvb-pll: Remove usage of the deprecated ida_simple_xx() API
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 11 Jan 2024 21:33:44 +0000 (22:33 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 7 Feb 2024 04:54:08 +0000 (05:54 +0100)
ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_max() is inclusive. So a -1 has been added when needed.

Link: https://lore.kernel.org/linux-media/920639b9e05775eea56ecb9cd5ed38ad292a96a8.1705008803.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/dvb-frontends/dvb-pll.c

index ef697ab6bc2e5287d02c5af55bc8f0359cf98523..1775a4aa0a186850789e45ee355a552f8cf94577 100644 (file)
@@ -796,7 +796,7 @@ struct dvb_frontend *dvb_pll_attach(struct dvb_frontend *fe, int pll_addr,
        b1[0] = 0;
        msg.buf = b1;
 
-       nr = ida_simple_get(&pll_ida, 0, DVB_PLL_MAX, GFP_KERNEL);
+       nr = ida_alloc_max(&pll_ida, DVB_PLL_MAX - 1, GFP_KERNEL);
        if (nr < 0) {
                kfree(b1);
                return NULL;
@@ -862,7 +862,7 @@ struct dvb_frontend *dvb_pll_attach(struct dvb_frontend *fe, int pll_addr,
        return fe;
 out:
        kfree(b1);
-       ida_simple_remove(&pll_ida, nr);
+       ida_free(&pll_ida, nr);
 
        return NULL;
 }
@@ -905,7 +905,7 @@ static void dvb_pll_remove(struct i2c_client *client)
        struct dvb_frontend *fe = i2c_get_clientdata(client);
        struct dvb_pll_priv *priv = fe->tuner_priv;
 
-       ida_simple_remove(&pll_ida, priv->nr);
+       ida_free(&pll_ida, priv->nr);
        dvb_pll_release(fe);
 }