i2c: algos: bit: mention our experience about initial states
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 16 Jun 2018 13:37:57 +0000 (22:37 +0900)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 29 Jun 2018 06:19:51 +0000 (08:19 +0200)
So, if somebody wants to re-implement this in the future, we pinpoint to
a problem case.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/algos/i2c-algo-bit.c

index 0c0eb16d710ff57d72f8a42210f7500b2fd0c458..6ec65adaba49569ab7b9775f856859a0fcfbd967 100644 (file)
@@ -647,6 +647,11 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
        if (bit_adap->getscl == NULL)
                adap->quirks = &i2c_bit_quirk_no_clk_stretch;
 
+       /*
+        * We tried forcing SCL/SDA to an initial state here. But that caused a
+        * regression, sadly. Check Bugzilla #200045 for details.
+        */
+
        ret = add_adapter(adap);
        if (ret < 0)
                return ret;