openvswitch: vlan: remove wrong likely statement
authorJiri Benc <jbenc@redhat.com>
Mon, 10 Oct 2016 15:02:42 +0000 (17:02 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Oct 2016 14:03:23 +0000 (10:03 -0400)
This code is called whenever flow key is being extracted from the packet.
The packet may be as likely vlan tagged as not.

Fixes: 018c1dda5ff1 ("openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes")
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Acked-by: Eric Garver <e@erig.me>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/flow.c

index c8c82e109c6893c4dc1a8f5bbff72849b7cab205..22087062bd1013e7c526dc95bce379bcaaebc4b9 100644 (file)
@@ -343,7 +343,7 @@ static int parse_vlan(struct sk_buff *skb, struct sw_flow_key *key)
        key->eth.cvlan.tci = 0;
        key->eth.cvlan.tpid = 0;
 
-       if (likely(skb_vlan_tag_present(skb))) {
+       if (skb_vlan_tag_present(skb)) {
                key->eth.vlan.tci = htons(skb->vlan_tci);
                key->eth.vlan.tpid = skb->vlan_proto;
        } else {