PM / OPP: Don't create debugfs "supply-0" directory unnecessarily
authorViresh Kumar <viresh.kumar@linaro.org>
Tue, 23 May 2017 04:02:13 +0000 (09:32 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 22 Jun 2017 01:15:30 +0000 (03:15 +0200)
We create "supply-0" debugfs directory even if the device doesn't do
voltage scaling. That looks confusing, as if the regulator is found but
we never managed to get voltage levels for it.

Avoid creating such a directory unnecessarily.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/opp/debugfs.c

index 95f433db4ac709bdf003b5a52e28008c77a75425..81cf120fcf4338c838218a4f7e2eea3e0af8170b 100644 (file)
@@ -40,11 +40,10 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
                                      struct dentry *pdentry)
 {
        struct dentry *d;
-       int i = 0;
+       int i;
        char *name;
 
-       /* Always create at least supply-0 directory */
-       do {
+       for (i = 0; i < opp_table->regulator_count; i++) {
                name = kasprintf(GFP_KERNEL, "supply-%d", i);
 
                /* Create per-opp directory */
@@ -70,7 +69,7 @@ static bool opp_debug_create_supplies(struct dev_pm_opp *opp,
                if (!debugfs_create_ulong("u_amp", S_IRUGO, d,
                                          &opp->supplies[i].u_amp))
                        return false;
-       } while (++i < opp_table->regulator_count);
+       }
 
        return true;
 }