mac80211: fix a buffer overrun in station debug code
authorJianjun Kong <jianjun@zeuux.org>
Tue, 11 Nov 2008 05:37:39 +0000 (21:37 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 11 Nov 2008 05:37:39 +0000 (21:37 -0800)
net/mac80211/debugfs_sta.c
The trailing zero was written to state[4], it's out of bounds.

Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mac80211/debugfs_sta.c

index 189d0bafa91ae0f274c2813f912012679f53903d..b85c4f27b3618e4f783f47c328b1b0c5f3e43702 100644 (file)
@@ -199,7 +199,7 @@ static ssize_t sta_agg_status_write(struct file *file,
                /* toggle Rx aggregation command */
                tid_num = tid_num - 100;
                if (tid_static_rx[tid_num] == 1) {
-                       strcpy(state, "off ");
+                       strcpy(state, "off");
                        ieee80211_sta_stop_rx_ba_session(sta->sdata, da, tid_num, 0,
                                        WLAN_REASON_QSTA_REQUIRE_SETUP);
                        sta->ampdu_mlme.tid_state_rx[tid_num] |=