bpf/xskmap: Return ERR_PTR for failure case instead of NULL.
authorJonathan Lemon <jonathan.lemon@gmail.com>
Tue, 24 Sep 2019 16:25:21 +0000 (09:25 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 25 Sep 2019 20:14:16 +0000 (22:14 +0200)
commitfcd30ae0665c778e283f73c1c885c7fd26d12ef2
tree2adc59ffd81cc960357f76910e7df660c9bb30f2
parent8a03222f508bf09e03cf38f6bd77b34b450c1d60
bpf/xskmap: Return ERR_PTR for failure case instead of NULL.

When kzalloc() failed, NULL was returned to the caller, which
tested the pointer with IS_ERR(), which didn't match, so the
pointer was used later, resulting in a NULL dereference.

Return ERR_PTR(-ENOMEM) instead of NULL.

Reported-by: syzbot+491c1b7565ba9069ecae@syzkaller.appspotmail.com
Fixes: 0402acd683c6 ("xsk: remove AF_XDP socket from map when the socket is released")
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Acked-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
kernel/bpf/xskmap.c