char: make misc_deregister a void function
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Jul 2015 22:59:57 +0000 (15:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Aug 2015 17:35:49 +0000 (10:35 -0700)
commitf368ed6088ae9c1fbe1c897bb5f215ce5e63fa1e
treea9ed27128f04f21ed0f205ec94a1ad0dbf746bb4
parent379e4f756b915bcc35958365e5d1326b3b54efce
char: make misc_deregister a void function

With well over 200+ users of this api, there are a mere 12 users that
actually checked the return value of this function.  And all of them
really didn't do anything with that information as the system or module
was shutting down no matter what.

So stop pretending like it matters, and just return void from
misc_deregister().  If something goes wrong in the call, you will get a
WARNING splat in the syslog so you know how to fix up your driver.
Other than that, there's nothing that can go wrong.

Cc: Alasdair Kergon <agk@redhat.com>
Cc: Neil Brown <neilb@suse.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wim Van Sebroeck <wim@iguana.be>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Acked-by: Joel Becker <jlbec@evilplan.org>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
16 files changed:
drivers/char/misc.c
drivers/md/dm-ioctl.c
drivers/misc/vmw_vmci/vmci_host.c
drivers/rtc/rtc-ds1374.c
drivers/staging/android/ashmem.c
drivers/staging/android/ion/ion_test.c
drivers/staging/lustre/lustre/libcfs/module.c
drivers/vhost/scsi.c
drivers/watchdog/at91rm9200_wdt.c
drivers/watchdog/ks8695_wdt.c
drivers/watchdog/ts72xx_wdt.c
fs/btrfs/super.c
fs/dlm/plock.c
fs/dlm/user.c
fs/ocfs2/stack_user.c
include/linux/miscdevice.h