mm: kasan: Ensure the tags are visible before the tag in page->flags
authorCatalin Marinas <catalin.marinas@arm.com>
Fri, 10 Jun 2022 15:21:38 +0000 (16:21 +0100)
committerWill Deacon <will@kernel.org>
Thu, 7 Jul 2022 09:48:37 +0000 (10:48 +0100)
commited0a6d1d973e9763989b44913ae1bd2a5d5d5777
tree59525214e06904d5cc0c020fea1e4e129d6172d7
parenta111daf0c53ae91e71fd2bfe7497862d14132e3e
mm: kasan: Ensure the tags are visible before the tag in page->flags

__kasan_unpoison_pages() colours the memory with a random tag and stores
it in page->flags in order to re-create the tagged pointer via
page_to_virt() later. When the tag from the page->flags is read, ensure
that the in-memory tags are already visible by re-ordering the
page_kasan_tag_set() after kasan_unpoison(). The former already has
barriers in place through try_cmpxchg(). On the reader side, the order
is ensured by the address dependency between page->flags and the memory
access.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lore.kernel.org/r/20220610152141.2148929-2-catalin.marinas@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
mm/kasan/common.c