irqchip/ti-sci-inta: Fix kernel crash if irq_create_fwspec_mapping fail
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Tue, 4 Jun 2019 10:17:51 +0000 (13:17 +0300)
committerMarc Zyngier <marc.zyngier@arm.com>
Wed, 5 Jun 2019 08:35:11 +0000 (09:35 +0100)
commiteb737b8f446044df327b30f24416be0cae35d4aa
treeb238b87ac56f44f7e82e8b3d10d648411c98acae
parentdb56c5128e6625cb16efc4910b60627e46f608e3
irqchip/ti-sci-inta: Fix kernel crash if irq_create_fwspec_mapping fail

irq_create_fwspec_mapping() can fail, returning 0 as parent_virq. In this
case vint_desc is going to be NULL in ti_sci_inta_alloc_irq() which will
cause NULL pointer dereference.

Also note that irq_create_fwspec_mapping() returns 'unsigned int' so the
check '<=' was wrong.

Use -EINVAL if irq_create_fwspec_mapping() returned with 0.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-ti-sci-inta.c