bridge: resolve a false alarm of lockdep
authorWANG Cong <xiyou.wangcong@gmail.com>
Thu, 16 Mar 2017 17:32:42 +0000 (10:32 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 17 Mar 2017 04:29:20 +0000 (21:29 -0700)
commitd12c917691b45d9dffcfe7c2362d25caa40905fd
treef2e7a8d5f346f39bc220147fcfc5b3a70c9f8999
parent4d4a6ac73e7466c2085c307fac41f74ce4568a45
bridge: resolve a false alarm of lockdep

Andrei reported a false alarm of lockdep at net/bridge/br_fdb.c:109,
this is because in Andrei's case, a spin_bug() was already triggered
before this, therefore the debug_locks is turned off, lockdep_is_held()
is no longer accurate after that. We should use lockdep_assert_held_once()
instead of lockdep_is_held() to respect debug_locks.

Fixes: 410b3d48f5111 ("bridge: fdb: add proper lock checks in searching functions")
Reported-by: Andrei Vagin <avagin@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_fdb.c
net/bridge/br_private.h