cgroup: css_task_iter_skip()'d iterators must be advanced before accessed
authorTejun Heo <tj@kernel.org>
Wed, 5 Jun 2019 16:54:34 +0000 (09:54 -0700)
committerTejun Heo <tj@kernel.org>
Wed, 5 Jun 2019 16:54:34 +0000 (09:54 -0700)
commitcee0c33c546a93957a52ae9ab6bebadbee765ec5
tree677530356898bb2d9b4633f2a39065788ff2a619
parentc03cd7738a83b13739f00546166969342c8ff014
cgroup: css_task_iter_skip()'d iterators must be advanced before accessed

b636fd38dc40 ("cgroup: Implement css_task_iter_skip()") introduced
css_task_iter_skip() which is used to fix task iterations skipping
dying threadgroup leaders with live threads.  Skipping is implemented
as a subportion of full advancing but css_task_iter_next() forgot to
fully advance a skipped iterator before determining the next task to
visit causing it to return invalid task pointers.

Fix it by making css_task_iter_next() fully advance the iterator if it
has been skipped since the previous iteration.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: syzbot
Link: http://lkml.kernel.org/r/00000000000097025d058a7fd785@google.com
Fixes: b636fd38dc40 ("cgroup: Implement css_task_iter_skip()")
kernel/cgroup/cgroup.c