kprobes, x86/ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 17 Oct 2018 20:59:51 +0000 (16:59 -0400)
committerIngo Molnar <mingo@kernel.org>
Thu, 18 Oct 2018 06:28:35 +0000 (08:28 +0200)
commitc2712b858187f5bcd7b042fe4daa3ba3a12635c0
treecbf147c76c6aadc067dc813aaa652ca4cb42e2ae
parentd4ae552982de39417d17f823df1f06b1cbc3686c
kprobes, x86/ptrace.h: Make regs_get_kernel_stack_nth() not fault on bad stack

Andy had some concerns about using regs_get_kernel_stack_nth() in a new
function regs_get_kernel_argument() as if there's any error in the stack
code, it could cause a bad memory access. To be on the safe side, call
probe_kernel_read() on the stack address to be extra careful in accessing
the memory. A helper function, regs_get_kernel_stack_nth_addr(), was added
to just return the stack address (or NULL if not on the stack), that will be
used to find the address (and could be used by other functions) and read the
address with kernel_probe_read().

Requested-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20181017165951.09119177@gandalf.local.home
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/ptrace.h