firewire: enforce access order between generation and node ID, fix "giving up on...
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 25 Jan 2008 17:57:41 +0000 (18:57 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Wed, 30 Jan 2008 21:22:27 +0000 (22:22 +0100)
commitb5d2a5e04e6a26cb3f77af8cbc31e74c361d706c
treecfc3b2dc141f643bcf6ef065cca802340b335799
parentcf5a56ac8083dd04ffe8b9b2ec7895e9bcff44bc
firewire: enforce access order between generation and node ID, fix "giving up on config rom"

fw_device.node_id and fw_device.generation are accessed without mutexes.
We have to ensure that all readers will get to see node_id updates
before generation updates.

Fixes an inability to recognize devices after "giving up on config rom",
https://bugzilla.redhat.com/show_bug.cgi?id=429950

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Reviewed by Nick Piggin <nickpiggin@yahoo.com.au>.

Verified to fix 'giving up on config rom' issues on multiple system and
drive combinations that were previously affected.

Signed-off-by: Jarod Wilson <jwilson@redhat.com>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
drivers/firewire/fw-cdev.c
drivers/firewire/fw-device.c
drivers/firewire/fw-device.h
drivers/firewire/fw-sbp2.c
drivers/firewire/fw-topology.c