net: phy: phylink: ensure the carrier is off when starting phylink
authorAntoine Tenart <antoine.tenart@bootlin.com>
Wed, 19 Sep 2018 09:39:31 +0000 (11:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Sep 2018 04:15:01 +0000 (21:15 -0700)
commitaeeb2e8fdefdd5d257a1446351c70cb3df540199
tree278f23ca831a60e533a761338e8ff7e331a9b015
parent02f7f61e5af2fa4748d610b8e4b1af70a44dcbe3
net: phy: phylink: ensure the carrier is off when starting phylink

Phylink made an assumption about the carrier state being down when
calling phylink_start(). If this assumption isn't satisfied, the
internal phylink state could misbehave and a net device could end up not
being functional.

This patch fixes this by explicitly calling netif_carrier_off() in
phylink_start().

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c