scsi: qla2xxx: Avoid that qlt_send_resp_ctio() corrupts memory
authorBart Van Assche <bvanassche@acm.org>
Wed, 17 Apr 2019 21:44:42 +0000 (14:44 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 29 Apr 2019 21:24:51 +0000 (17:24 -0400)
commita861b49273578e255426a499842cf7f465456351
tree4eed5f27352f52a980cc18b3309b0fcf2d23196c
parent300ec7415c1fed5c73660f50c8e14a67e236dc0a
scsi: qla2xxx: Avoid that qlt_send_resp_ctio() corrupts memory

The "(&ctio->u.status1.sense_data)[i]" where i >= 0 expressions in
qlt_send_resp_ctio() are probably typos and should have been
"(&ctio->u.status1.sense_data[4 * i])" instead. Instead of only fixing
these typos, modify the code for storing sense data such that it becomes
easy to read. This patch fixes a Coverity complaint about accessing an
array outside its bounds.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Fixes: be25152c0d9e ("qla2xxx: Improve T10-DIF/PI handling in driver.") # v4.11.
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c