projects / linux-2.6-block.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: e65cc19) | patch
drivers/ata/libata: Move dereference after NULL test
authorJulia Lawall <julia@diku.dk>
Sat, 17 Oct 2009 06:41:47 +0000 (08:41 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 3 Nov 2009 19:26:12 +0000 (14:26 -0500)
commita1104016ce8f7750ecd8ca6129786bc549aa5c38
tree362350c913218858952d4c09b18bd3cd59969958tree | snapshot
parente65cc194f7628ecaa02462f22f42fb09b50dcd49commit | diff
drivers/ata/libata: Move dereference after NULL test

In each case, if the NULL test on qc is needed, then the derefernce
should be after the NULL test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-core.c diff | blob | blame | history
Linux 6.x block layer and io_uring tree(s)